From 9d3231747ea271167e85920a583c54f4570173b8 Mon Sep 17 00:00:00 2001
From: amichelo <andrea.michelotti@lnf.infn.it>
Date: Wed, 20 Oct 2021 16:21:27 +0200
Subject: [PATCH] no empty key
---
chaos/common/message/MessagePSConsumer.cpp | 4 ++++
.../message/impl/kafka/rdk/MessagePSRDKafkaConsumer.cpp | 5 ++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/chaos/common/message/MessagePSConsumer.cpp b/chaos/common/message/MessagePSConsumer.cpp
index 006ba33e1..d4d4214e4 100644
--- a/chaos/common/message/MessagePSConsumer.cpp
+++ b/chaos/common/message/MessagePSConsumer.cpp
@@ -69,6 +69,10 @@ ele_uptr_t MessagePSConsumer::getMsg(int timeo) {
int MessagePSConsumer::subscribe(const std::string& key) {
std::string topic = key;
+ if(key.size()==0){
+ MRDERR_ << " empty subscription name";
+ return -1;
+ }
std::replace(topic.begin(), topic.end(), '/', '.');
std::replace(topic.begin(), topic.end(), ':', '.');
diff --git a/chaos/common/message/impl/kafka/rdk/MessagePSRDKafkaConsumer.cpp b/chaos/common/message/impl/kafka/rdk/MessagePSRDKafkaConsumer.cpp
index b3e42ce64..6c80a5e72 100644
--- a/chaos/common/message/impl/kafka/rdk/MessagePSRDKafkaConsumer.cpp
+++ b/chaos/common/message/impl/kafka/rdk/MessagePSRDKafkaConsumer.cpp
@@ -145,7 +145,10 @@ int MessagePSRDKafkaConsumer::applyConfiguration() {
}
int MessagePSRDKafkaConsumer::subscribe(const std::string& key) {
- MessagePSConsumer::subscribe(key);
+ int ret=MessagePSConsumer::subscribe(key);
+ if(ret!=0){
+ return ret;
+ }
if (rk == NULL) {
errstr = "apply configuration first!";
MRDERR_ << errstr;
--
GitLab