diff --git a/documentation/RELEASE_NOTES.html b/documentation/RELEASE_NOTES.html index 47babb91bde4bf421a123ce1da1358001b84b4fd..7d1e8b8422c1256f13d24105fad0226764eda047 100644 --- a/documentation/RELEASE_NOTES.html +++ b/documentation/RELEASE_NOTES.html @@ -13,6 +13,12 @@ <!-- Insert new items immediately below here ... --> +<h4>Problem with NAN values in MLST/ALST fields</h4> + +<p>The ai, ao, calc, calcout, dfanout, sel and sub record types could stop +posting monitors if they got NAN values in their MLST or ALST fields. A change +has been included so this should no longer be the case.</p> + <h4>MacOS build defaults changed</h4> <p>The default build settings for darwin-x86 targets have been changed to match diff --git a/src/rec/aiRecord.c b/src/rec/aiRecord.c index 343d62126e2dd72f65e3b70eea1cb2552c2729ca..e6977005fb305fb8a09cb009a82fc15a82953200 100644 --- a/src/rec/aiRecord.c +++ b/src/rec/aiRecord.c @@ -385,7 +385,7 @@ static void monitor(aiRecord *prec) /* check for value change */ delta = prec->mlst - prec->val; if(delta<0.0) delta = -delta; - if (delta > prec->mdel) { + if (!(delta <= prec->mdel)) { /* Handles MDEL == NAN */ /* post events for value change */ monitor_mask |= DBE_VALUE; /* update last value monitored */ @@ -395,7 +395,7 @@ static void monitor(aiRecord *prec) /* check for archive change */ delta = prec->alst - prec->val; if(delta<0.0) delta = -delta; - if (delta > prec->adel) { + if (!(delta <= prec->adel)) { /* Handles ADEL == NAN */ /* post events on value field for archive change */ monitor_mask |= DBE_LOG; /* update last archive value monitored */ diff --git a/src/rec/aoRecord.c b/src/rec/aoRecord.c index 5f8436ab24bd2236b845396003ae9e405d4085c5..bce43e3e4f1a9201eab36b5f57f72a74ffce389a 100644 --- a/src/rec/aoRecord.c +++ b/src/rec/aoRecord.c @@ -484,7 +484,7 @@ static void monitor(aoRecord *prec) /* check for value change */ delta = prec->mlst - prec->val; if(delta<0.0) delta = -delta; - if (delta > prec->mdel) { + if (!(delta <= prec->mdel)) { /* Handles MDEL == NAN */ /* post events for value change */ monitor_mask |= DBE_VALUE; /* update last value monitored */ @@ -493,7 +493,7 @@ static void monitor(aoRecord *prec) /* check for archive change */ delta = prec->alst - prec->val; if(delta<0.0) delta = -delta; - if (delta > prec->adel) { + if (!(delta <= prec->adel)) { /* Handles ADEL == NAN */ /* post events on value field for archive change */ monitor_mask |= DBE_LOG; /* update last archive value monitored */ diff --git a/src/rec/calcRecord.c b/src/rec/calcRecord.c index 722ce069822a2b6d756df3256e50e6df1af4ae3d..8accf60d9d10f4d2e97d2312ad1a8c7c3d4ad9b1 100644 --- a/src/rec/calcRecord.c +++ b/src/rec/calcRecord.c @@ -310,7 +310,7 @@ static void monitor(calcRecord *prec) /* check for value change */ delta = prec->mlst - prec->val; if (delta < 0.0) delta = -delta; - if (delta > prec->mdel) { + if (!(delta <= prec->mdel)) { /* Handles MDEL == NAN */ /* post events for value change */ monitor_mask |= DBE_VALUE; /* update last value monitored */ @@ -319,7 +319,7 @@ static void monitor(calcRecord *prec) /* check for archive change */ delta = prec->alst - prec->val; if (delta < 0.0) delta = -delta; - if (delta > prec->adel) { + if (!(delta <= prec->adel)) { /* Handles ADEL == NAN */ /* post events on value field for archive change */ monitor_mask |= DBE_LOG; /* update last archive value monitored */ diff --git a/src/rec/calcoutRecord.c b/src/rec/calcoutRecord.c index 0b7c78323ad3270953d1f690ba50184a8642d930..89265f3cc3b2cabfad022141901aa5c2a6fc502a 100644 --- a/src/rec/calcoutRecord.c +++ b/src/rec/calcoutRecord.c @@ -209,7 +209,7 @@ static long init_record(calcoutRecord *prec, int pass) static long process(calcoutRecord *prec) { rpvtStruct *prpvt = prec->rpvt; - int doOutput = 0; + int doOutput; if (!prec->pact) { prec->pact = TRUE; @@ -231,21 +231,22 @@ static long process(calcoutRecord *prec) doOutput = 1; break; case calcoutOOPT_On_Change: - if (fabs(prec->pval - prec->val) > prec->mdel) doOutput = 1; + doOutput = ! (fabs(prec->pval - prec->val) <= prec->mdel); break; case calcoutOOPT_Transition_To_Zero: - if ((prec->pval != 0.0) && (prec->val == 0.0)) doOutput = 1; + doOutput = ((prec->pval != 0.0) && (prec->val == 0.0)); break; case calcoutOOPT_Transition_To_Non_zero: - if ((prec->pval == 0.0) && (prec->val != 0.0)) doOutput = 1; + doOutput = ((prec->pval == 0.0) && (prec->val != 0.0)); break; case calcoutOOPT_When_Zero: - if (prec->val == 0.0) doOutput = 1; + doOutput = (prec->val == 0.0); break; case calcoutOOPT_When_Non_zero: - if (prec->val != 0.0) doOutput = 1; + doOutput = (prec->val != 0.0); break; default: + doOutput = 0; break; } prec->pval = prec->val; @@ -584,7 +585,7 @@ static void monitor(calcoutRecord *prec) /* check for value change */ delta = prec->mlst - prec->val; if (delta<0.0) delta = -delta; - if (delta > prec->mdel) { + if (!(delta <= prec->mdel)) { /* Handles MDEL == NAN */ /* post events for value change */ monitor_mask |= DBE_VALUE; /* update last value monitored */ @@ -593,7 +594,7 @@ static void monitor(calcoutRecord *prec) /* check for archive change */ delta = prec->alst - prec->val; if (delta<0.0) delta = -delta; - if (delta > prec->adel) { + if (!(delta <= prec->adel)) { /* Handles ADEL == NAN */ /* post events on value field for archive change */ monitor_mask |= DBE_LOG; /* update last archive value monitored */ diff --git a/src/rec/dfanoutRecord.c b/src/rec/dfanoutRecord.c index 672c1cccd4c66a87442fc153287086a1a39e3218..723d1a59c43e787e4ae4a98851b7423e6118d509 100644 --- a/src/rec/dfanoutRecord.c +++ b/src/rec/dfanoutRecord.c @@ -267,7 +267,7 @@ static void monitor(dfanoutRecord *prec) /* check for value change */ delta = prec->mlst - prec->val; if(delta<0) delta = -delta; - if (delta > prec->mdel) { + if (!(delta <= prec->mdel)) { /* Handles MDEL == NAN */ /* post events for value change */ monitor_mask |= DBE_VALUE; /* update last value monitored */ @@ -276,7 +276,7 @@ static void monitor(dfanoutRecord *prec) /* check for archive change */ delta = prec->alst - prec->val; if(delta<0) delta = -delta; - if (delta > prec->adel) { + if (!(delta <= prec->adel)) { /* Handles ADEL == NAN */ /* post events on value field for archive change */ monitor_mask |= DBE_LOG; /* update last archive value monitored */ diff --git a/src/rec/selRecord.c b/src/rec/selRecord.c index 6bc43c227b0d417ff3221048dde0b5e5a9a9d413..6174dab3d0949e49a7639a24a75c75bf801f251c 100644 --- a/src/rec/selRecord.c +++ b/src/rec/selRecord.c @@ -300,7 +300,7 @@ static void monitor(selRecord *prec) /* check for value change */ delta = prec->mlst - prec->val; if(delta<0.0) delta = -delta; - if (delta > prec->mdel) { + if (!(delta <= prec->mdel)) { /* Handles MDEL == NAN */ /* post events for value change */ monitor_mask |= DBE_VALUE; /* update last value monitored */ @@ -309,7 +309,7 @@ static void monitor(selRecord *prec) /* check for archive change */ delta = prec->alst - prec->val; if(delta<0.0) delta = -delta; - if (delta > prec->adel) { + if (!(delta <= prec->adel)) { /* Handles ADEL == NAN */ /* post events on value field for archive change */ monitor_mask |= DBE_LOG; /* update last archive value monitored */ diff --git a/src/rec/subRecord.c b/src/rec/subRecord.c index c07de569294ad35b6102f15ba282df8e4cfd8848..b16a89c3c07ce24cccc2853096c79fcbe0dd780b 100644 --- a/src/rec/subRecord.c +++ b/src/rec/subRecord.c @@ -353,7 +353,7 @@ static void monitor(subRecord *prec) /* check for value change */ delta = prec->val - prec->mlst; if (delta < 0.0) delta = -delta; - if (delta > prec->mdel) { + if (!(delta <= prec->mdel)) { /* Handles MDEL == NAN */ /* post events for value change */ monitor_mask |= DBE_VALUE; /* update last value monitored */ @@ -362,7 +362,7 @@ static void monitor(subRecord *prec) /* check for archive change */ delta = prec->val - prec->alst; if (delta < 0.0) delta = -delta; - if (delta > prec->adel) { + if (!(delta <= prec->adel)) { /* Handles ADEL == NAN */ /* post events on value field for archive change */ monitor_mask |= DBE_LOG; /* update last archive value monitored */